Add subtarget information to a test target name #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets users know which subtarget failed, which is crucial when testing multiple test subtargets (e.g. when there is one per configuration, generated via transitions). Before: ``` 2 TESTS FAILED ✗ root//:dummy_test ✗ root//:dummy_test ``` After: ``` 2 TESTS FAILED ✗ root//:dummy_test[gcc13-cxx20-debug] ✗ root//:dummy_test[clang18-cxx20-debug] ``` When a default provider is built (no subtargets), the output is unchanged, because `ProviderName`'s `Display` implementation returns an empty string for default providers.
facebook-github-bot
added
the
CLA Signed
|
@JakobDegen Those Windows failures are unrelated, so I think that the patch is ready. |
|
@ndmitchell Could you have a look at this, or alternatively who I should tag as a reviewer? |
|
@stepancheg maybe? Sorry for insisting, this has just come up again internally. |
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets users know which subtarget failed, which is crucial when testing multiple test subtargets (e.g. when there is one per configuration, generated via transitions).
Before:
After:
When a default provider is built (no subtargets), the output is unchanged, because
ProviderName'sDisplayimplementation returns an empty string for default providers.