cmd/evm: refactor handling output-files for t8n
#30854
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
requested review from
MariusVanDerWijden and
lightclient
as code owners
holiman
force-pushed
the
fix_evmlogs_onmaster
branch
7 times, most recently
from
07087f8 to
4f8c66c
Compare
holiman
force-pushed
the
fix_evmlogs_onmaster
branch
from
4f8c66c to
118fa6b
Compare
holiman
force-pushed
the
fix_evmlogs_onmaster
branch
from
7a70999 to
28ea519
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of trying to make the inputs and outputs of the evm subcommands more streamlined and aligned, this PR modifies how
evm t8nmanages output-files.Previously, we do a kind of wonky thing where between each transaction, we invoke a
getTracerclosure. In that closure, we create a new output-file, a tracer, and then make the tracer stream output to the file. We also fiddle a bit to ensure that the file becomes properly closed.It is a kind of hacky solution we have in place. This PR changes it, so that from the execution-pipeline point of view, we have just a regular tracer. No fiddling with re-setting it or closing files.
That particular tracer, however, is a bit special: it takes care of creating new files per transaction (in the tx-start-hook) and closing (on tx-end-hook). Also instantiating the right type of underlying tracer, which can be a json-logger or a custom tracer.