Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ESLint 8.x #219

Merged
merged 1 commit into from
Dec 18, 2021

Conversation

MichaelDeBoey
Copy link
Member

@MichaelDeBoey MichaelDeBoey commented Oct 11, 2021

ESLint v8.0.0 is released 🎉

devDependency compatibility with ESLint 8:


Closes #218

@voxpelli
Copy link
Member

Some changes needs to be made to the rules of this plugin:

  • eslint-plugin/require-meta-schema doesn't pass on many of them
  • eslint-plugin/prefer-object-rule doesn't pass on some of them

@alexander-akait
Copy link

@MichaelDeBoey Can you fix the problems? Thanks

Copy link
Member Author

@MichaelDeBoey MichaelDeBoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexander-akait I'm not sure if these schemas are correct.
Please check them out.

rules/catch-or-return.js Outdated Show resolved Hide resolved
rules/no-callback-in-promise.js Outdated Show resolved Hide resolved
rules/no-return-wrap.js Outdated Show resolved Hide resolved
@cobaltt7
Copy link

cobaltt7 commented Nov 7, 2021

why do dev dependencies need to be compatible? you can still use v7 for lining this, right?

@cobaltt7 cobaltt7 mentioned this pull request Nov 7, 2021
@koooge
Copy link

koooge commented Nov 7, 2021

Hi there, I need this peerDeps change to update eslint with npm@8.

eslint-plugin-node seems to support eslint 5+. https://github.com/mysticatea/eslint-plugin-node/blob/master/package.json#L12-L14

So I suppose eslint-plugin-promise doesn't need to wait to update it. What is your concern about? @MichaelDeBoey

package.json Outdated Show resolved Hide resolved
gajus added a commit to gajus/eslint-config-canonical that referenced this pull request Nov 17, 2021
gajus added a commit to gajus/eslint-config-canonical that referenced this pull request Nov 19, 2021
It is essentially broken at the moment.
Waiting for the following PR to get merged:
eslint-community/eslint-plugin-promise#219
@niksy
Copy link

niksy commented Nov 26, 2021

@xjamundx what can we do to help to get this merged?

@MichaelDeBoey
Copy link
Member Author

@voxpelli @niksy @xjamundx I've merged #227, #228, #229, #230 & #231 and added one last commit to support ESLint v8.x

@niksy
Copy link

niksy commented Dec 13, 2021

@xjamundx I thinks PR’s that @MichaelDeBoey created are good enough to review as opposed to one large PR. This will make updating to latest ESLint easier.

@MichaelDeBoey
Copy link
Member Author

Ping @xjamundx

@xjamundx
Copy link
Contributor

okay let me take a look at everything this weekend. would love to get this published soon

@MichaelDeBoey
Copy link
Member Author

@xjamundx if you need any help, you can always ping me 😉

@MichaelDeBoey MichaelDeBoey marked this pull request as ready for review December 18, 2021 00:52
@MichaelDeBoey
Copy link
Member Author

MichaelDeBoey commented Dec 18, 2021

@xjamundx This one can be merged now

@xjamundx xjamundx merged commit ff1ad03 into eslint-community:development Dec 18, 2021
@MichaelDeBoey MichaelDeBoey deleted the eslint-8 branch December 18, 2021 00:54
@MichaelDeBoey
Copy link
Member Author

@xjamundx Thanks for taking the time to merge this!

If you're publishing a new version, be sure to make it a major, as we've dropped Node 10

@xjamundx
Copy link
Contributor

xjamundx commented Dec 18, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ESLint 8.x