-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable rate limit for month and year #4495
base: main
Are you sure you want to change the base?
Conversation
5530a7e
to
6e7e1be
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4495 +/- ##
==========================================
- Coverage 65.95% 65.74% -0.21%
==========================================
Files 203 210 +7
Lines 31154 31524 +370
==========================================
+ Hits 20547 20726 +179
- Misses 9420 9602 +182
- Partials 1187 1196 +9 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
thanks for the submitting the PR @rpahli ! you probably need a few more changes
can you also add a test case in https://github.com/envoyproxy/gateway/tree/main/internal/xds/translator/testdata/in/ratelimit-config / https://github.com/envoyproxy/gateway/tree/main/internal/xds/translator/testdata/out/ratelimit-config and an addition to https://github.com/envoyproxy/gateway/blob/main/test/e2e/tests/ratelimit.go to make sure it works e2e |
411e760
to
a2cafb6
Compare
Signed-off-by: Rico Pahlisch <[email protected]> Signed-off-by: Rico Pahlisch <[email protected]>
a2cafb6
to
d123cb6
Compare
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions! |
unstale |
What type of PR is this?
adds the option to set rate limit unit to
Month
andYear
which was introduced with envoy 1.25.What this PR does / why we need it:
Which issue(s) this PR fixes: