Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable rate limit for month and year #4495

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rpahli
Copy link

@rpahli rpahli commented Oct 22, 2024

What type of PR is this?

adds the option to set rate limit unit to Month and Year which was introduced with envoy 1.25.

What this PR does / why we need it:

Which issue(s) this PR fixes:

@rpahli rpahli requested a review from a team as a code owner October 22, 2024 14:09
@rpahli rpahli force-pushed the rate-limit-month-year branch 2 times, most recently from 5530a7e to 6e7e1be Compare October 22, 2024 14:12
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 65.74%. Comparing base (544bd9c) to head (d123cb6).
Report is 132 commits behind head on main.

Files with missing lines Patch % Lines
internal/gatewayapi/backendtrafficpolicy.go 0.00% 4 Missing ⚠️
internal/xds/translator/local_ratelimit.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4495      +/-   ##
==========================================
- Coverage   65.95%   65.74%   -0.21%     
==========================================
  Files         203      210       +7     
  Lines       31154    31524     +370     
==========================================
+ Hits        20547    20726     +179     
- Misses       9420     9602     +182     
- Partials     1187     1196       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@rpahli rpahli force-pushed the rate-limit-month-year branch 2 times, most recently from 411e760 to a2cafb6 Compare October 23, 2024 08:22
Signed-off-by: Rico Pahlisch <[email protected]>
Signed-off-by: Rico Pahlisch <[email protected]>
Copy link

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale label Nov 23, 2024
@rpahli
Copy link
Author

rpahli commented Dec 13, 2024

unstale

@github-actions github-actions bot removed the stale label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants