Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align target names for opentelemetry-proto with BCR #37662

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mering
Copy link

@mering mering commented Dec 14, 2024

Align target names for opentelemetry-proto with Bazel Central Registry.

This is a requirement for compatibility with Bzlmod.

Copy link

Hi @mering, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

🐱

Caused by: #37662 was opened by mering.

see: more, trace.

@repokitteh-read-only repokitteh-read-only bot added api deps Approval required for changes to Envoy's external dependencies labels Dec 14, 2024
Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @markdroth
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @phlax

🐱

Caused by: #37662 was opened by mering.

see: more, trace.

@mering mering marked this pull request as draft December 14, 2024 16:11
@mering mering force-pushed the align-opentelemetry-proto-bcr branch 3 times, most recently from 9cae88f to 253f0f5 Compare December 14, 2024 17:20
This is a requirement for compatibility with Bzlmod.

Signed-off-by: maleo <[email protected]>
@mering mering force-pushed the align-opentelemetry-proto-bcr branch from 253f0f5 to e9401ff Compare December 14, 2024 17:45
@mering mering marked this pull request as ready for review December 14, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api deps Approval required for changes to Envoy's external dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants