[WIP/TESTING] mobile/deps: Bump rules_android -> 0.6.0
#37661
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Northey <[email protected]>
phlax
requested review from
RyanTheOptimist,
alyssawilk,
abeyad and
fredyw
as code owners
repokitteh-read-only
bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
moderation
suggested changes
Dec 14, 2024
Comment on lines
+100
to
+102
| urls = ["https://github.com/bazelbuild/rules_android/archive/refs/tags/v0.6.0.zip"], | ||
| sha256 = "691c90615ebf66aa474fdd5e17b92d54f62e5e3627f4eb224e9321cfcf5fe83f", | ||
| strip_prefix = "rules_android-0.6.0", |
There was a problem hiding this comment.
Seeing more /refs/tags/ creeping into the dependency URLs which makes sens as that is what GitHub uses on the page now. The links work without it though and are cleaner. Almost all the links omit the /refs/tags/. Wondering if we should standardardize?
As per dependency standards we should use the maintainer provided binary here
urls = ["https://github.com/bazelbuild/rules_android/releases/download/v0.6.0/rules_android-v0.6.0.tar.gz"],
sha256 = "af84b69ab3d16dd1a41056286e6511f147a94ccea995603e13e934c915c1631c",
strip_prefix = "rules_android-0.6.0",
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.