Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP/TESTING] mobile: Add rules_android_ndk #37648

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

phlax
Copy link
Member

@phlax phlax commented Dec 13, 2024

No description provided.

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Dec 13, 2024
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @RyanTheOptimist

🐱

Caused by: #37648 was opened by phlax.

see: more, trace.

Signed-off-by: Ryan Northey <[email protected]>
@phlax phlax changed the title mobile: Add rules_android_ndk [WIP/TESTING] mobile: Add rules_android_ndk Dec 13, 2024
@phlax
Copy link
Member Author

phlax commented Dec 13, 2024

cc @keith i had a go at adding rules_android_ndk again - but without updating the ndk - it fails with foreign_cc issues - any ideas why?

@phlax
Copy link
Member Author

phlax commented Dec 13, 2024

fail:

CMakeFiles/cmTC_2eff2.dir/testCCompiler.c.o
    [2/2] Linking C executable cmTC_2eff2
    FAILED: cmTC_2eff2 
    : && /mnt/engflow/worker/work/1/exec/external/android_ndk/toolchains/llvm/prebuilt/linux-x86_64/bin/clang -no-canonical-prefixes --target=x86_64-linux-android21 -fdiagnostics-color -Wa,--noexecstack -faddrsig -faligned-new -fdata-sections -ffunction-sections -funsigned-char -fstack-protector -g -funwind-tables -DNDEBUG -fno-strict-aliasing -fomit-frame-pointer -g0 -Oz -Wall -Wformat-security -Wno-char-subscripts -Wno-error=deprecated-declarations -Wno-maybe-uninitialized -Wno-sign-compare -Wno-strict-overflow -Wno-unused-but-set-variable -Wunused-but-set-parameter -Wno-unknown-warning-option -Wno-unused-command-line-argument -Wno-ignored-optimization-argument -Wno-ambiguous-member-template -Wno-char-subscripts -Wno-error=deprecated-declarations -Wno-extern-c-compat -Wno-gnu-alignof-expression -Wno-gnu-variable-sized-type-not-at-end -Wno-implicit-int-float-conversion -Wno-invalid-source-encoding -Wno-mismatched-tags -Wno-pointer-sign -Wno-private-header -Wno-sign-compare -Wno-signed-unsigned-wchar -Wno-strict-overflow -Wno-trigraphs -Wno-unknown-pragmas -Wno-unused-const-variable -Wno-unused-function -Wno-unused-private-field -Wno-user-defined-warnings -Wno-extern-c-compat -Wno-gnu-alignof-expression -Wno-gnu-designator -Wno-gnu-variable-sized-type-not-at-end -Wno-invalid-source-encoding -Wno-mismatched-tags -Wno-reserved-user-defined-literal -Wno-return-type-c-linkage -Wno-self-assign-overloaded -Wno-tautological-constant-in-range-compare -Wno-unknown-pragmas -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wfor-loop-analysis -Wgnu-redeclared-enum -Winfinite-recursion -Wliteral-conversion -Wself-assign -Wstring-conversion -Wtautological-overlap-compare -Wunused-comparison -Wvla -Wthread-safety-analysis -fPIC -DABSL_MIN_LOG_LEVEL=4 -fdebug-types-section -Wno-deprecated-declarations -Wno-deprecated-declarations -Os -fvisibility=hidden -fexceptions -no-canonical-prefixes --target=x86_64-linux-android21 -fdiagnostics-color -Wl,-z,noexecstack -Wl,-zseparate-code -Wl,--no-rosegment -Wl,--gc-sections -Wl,--exclude-libs,libgcc.a -Wl,--build-id=md5 -Wl,--undefined-glob='Java_*' -Wl,--undefined-glob='JNI_*' -pie -Wl,--exclude-libs,libunwind.a -fuse-ld=lld -Wl,--icf=safe -Wl,--no-undefined -lc -lm -latomic -ldl CMakeFiles/cmTC_2eff2.dir/testCCompiler.c.o -o cmTC_2eff2   && :
    ld.lld: error: unknown -z value: separate-code
    clang: error: linker command failed with exit code 1 (use -v to see invocation)
    ninja: build stopped: subcommand failed.
    ```

@phlax phlax marked this pull request as draft December 13, 2024 13:53
@phlax
Copy link
Member Author

phlax commented Dec 13, 2024

im guessing its just that the compiler provided in this version of ndk is too old

@keith
Copy link
Member

keith commented Dec 13, 2024

yea i think so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps Approval required for changes to Envoy's external dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants