http: configurable ignore of HTTP/1.1 upgrades #37642
Conversation
Co-authored-by: Greg Greenway <[email protected]> Signed-off-by: Tom Edge <[email protected]>
|
Hi @tedgeat, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
|
@tedgeat 👋 , is it going to work for http2 upstreams too? |
There was a problem hiding this comment.
I don't think remove the unsupported upgrade type and treat the upgrade request as a normal http request is good choice. If clients ask envoy to upgrade but envoy cannot support, rejection would be best choice.
This change brings a new option to our core API and only for a special (or incorrect) hack.
cc @alyssawilk @envoyproxy/senior-maintainers for more input.
/wait
|
|
||
| // Ignore HTTP/1.1 upgrade headers rather than default rejection | ||
| bool ignore_http_11_upgrade = 11; |
There was a problem hiding this comment.
From the naming, the options will ignore all upgrade. But actually the implementation didn't works at that way.
Fixes #36305
Add configuration to ignore HTTP/1.1 Upgrade headers . See https://datatracker.ietf.org/doc/html/rfc7230#section-6.7:
Risk Level: Medium
Testing: new unit tests
Docs Changes: in with APIs
Release Notes: inline