Revert "ext_proc: Ext proc half close on destroy and defer reset till trailers received. (#37083)" #37639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… trailers received. (envoyproxy#37083)" This reverts commit 0b90f64. Signed-off-by: Yan Avlasov <[email protected]>
tyxia
approved these changes
Dec 12, 2024
|
Hi @yanavlasov, I noticed that you reverted PR #37083 due to suspected instability in production. I’ve started seeing Before this upgrade, even when there were upstream issues, I didn’t encounter Could you provide more details about the instability you experienced in production? For example:
Best regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional Description:
This PR is suspected of causing instability in prod. The cause is not yet fully diagnosed, but it is reverted as a safety measure.
Risk Level: Low
Testing: Unit tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A