Add filter state IP matcher #37637
Open
Add filter state IP matcher #37637
+258
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
|
/assign @markdroth |
|
/retest |
Signed-off-by: antoniovleonti <[email protected]>
antoniovleonti
force-pushed
the
gen_ip_range
branch
from
5587720 to
1cd6e9e
Compare
wbpcode
reviewed
Dec 16, 2024
Comment on lines
+31
to
+32
| // Matchers the filter state object as a ip Instance. | ||
| xds.core.v3.CidrRange ip_range = 3; |
There was a problem hiding this comment.
All exist CidrRanges in the envoy api repo now is config.core.v3.CidrRange, please use it for now before we sort out a way to migrate all common protos to xds repo.
And consider to naming it address_match or something. And should repeated be used to allow configuring multiple ranges?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Add filter state IP matcher
Additional Description:
This cl adds a matcher to the generic filter state matcher which attempts to coerce the specified filter state object into an IP, then matches it against a configured CIDR range. If the IP is in the range, the matcher returns true, otherwise false.
Risk Level: low
Testing: unit tested
Docs Changes: none
Release Notes: changelog updated
Platform Specific Features: none