Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobile: Default QUIC connection idle timeout to 60s #37633

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+2 −2
Open

mobile: Default QUIC connection idle timeout to 60s #37633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a2bb522
mobile: Default QUIC connection idle timeout to 60s
abeyad Dec 12, 2024
2b13dd5
Merge remote-tracking branch 'upstream/main' into quic-conn-idle-timeout
abeyad Dec 12, 2024
4ef762a
Merge remote-tracking branch 'upstream/main' into quic-conn-idle-timeout
abeyad Dec 12, 2024
b4152b4
fix test
abeyad Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mobile/library/cc/engine_builder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ class EngineBuilder {
// https://source.chromium.org/chromium/chromium/src/+/main:net/quic/quic_context.cc;l=21-22;drc=6849bf6b37e96bd1c38a5f77f7deaa28b53779c4;bpv=1;bpt=1
const uint32_t initial_stream_window_size_ = 6 * 1024 * 1024; // 6MB
const uint32_t initial_connection_window_size_ = 15 * 1024 * 1024; // 15MB
int quic_connection_idle_timeout_seconds_ = 30;
int quic_connection_idle_timeout_seconds_ = 60;

int keepalive_initial_interval_ms_ = 0;
};
Expand Down
2 changes: 1 addition & 1 deletion mobile/test/cc/unit/envoy_config_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ TEST(TestConfig, ConfigIsApplied) {
"canonical_suffixes: \".opq.com\"",
"canonical_suffixes: \".xyz.com\"",
"num_timeouts_to_trigger_port_migration { value: 4 }",
"idle_network_timeout { seconds: 30 }",
"idle_network_timeout { seconds: 60 }",
"key: \"dns_persistent_cache\" save_interval { seconds: 101 }",
"key: \"prefer_quic_client_udp_gro\" value { bool_value: true }",
"key: \"test_feature_false\" value { bool_value: true }",
Expand Down