Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process body format before update status code #37607

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

juanmolle
Copy link
Contributor

Commit Message: Local Reply process body formatter before update status code
Additional Description:

Local Reply process body formatter before update status code to avoid difference between processing headers and body

Risk Level: low
Testing: yes
Docs Changes: wip
Release Notes: wip
Platform Specific Features: no
Runtime guard: wip
Fixes #37577

Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #37607 was opened by juanmolle.

see: more, trace.

@wbpcode
Copy link
Member

wbpcode commented Dec 10, 2024

Thanks for the contribution. But you cannot change the exist behavior directly without any guard or strong reason, just because it doesn't meet your expectations.

@juanmolle
Copy link
Contributor Author

@wbpcode Thanks for reviewing, I know I cannot change any behavior without a guard. I have upload the change in WIP and draft just to complement the issue information.
Waiting for comments if this is an bug, Work as design, or just document RESPONSE_CODE will have a meaning when using to add headers and a different one when formatting the body.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

local_replay_config RESPONSE_CODE is override before body_format
2 participants