Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images: Remove centos build image #152

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

phlax
Copy link
Member

@phlax phlax commented Oct 1, 2021

Fix #149

@phlax phlax requested a review from a team as a code owner October 1, 2021 07:21
@phlax phlax force-pushed the remove-centos-build-image branch from 07edb61 to a93f17c Compare October 1, 2021 07:22
@phlax
Copy link
Member Author

phlax commented Oct 1, 2021

it seems as tho some users were using this image for building Envoy against lower versions of GLIBC in order to support centos7 (cf envoyproxy/envoy#18365)

im not sure if using this (unmaintained) image is the best way to do that, and it seems doing so is now broken anyway

@phlax
Copy link
Member Author

phlax commented Oct 1, 2021

cc @lizan @dmitri-d @Alexcei88

@Alexcei88
Copy link

Alexcei88 commented Oct 1, 2021

I think it is better if we will try to fix problems of build for centos7. Because envoy is working well on centos7. You honestly write that you do not support it, but anyone can try to build if he wants. Why delete

@phlax
Copy link
Member Author

phlax commented Oct 1, 2021

i agree that it would be good to maintain support for a centos7 build, im just not sure that this build-image is the best way to do that

@phlax
Copy link
Member Author

phlax commented Sep 12, 2024

closing in favour of #356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] Remove centos build image
2 participants