Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Cherry-pick inlining fix from #725" #745

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

jiribenes
Copy link
Contributor

Reverts #730 as it seems like an incorrect fix, judging both by the Effekt Working Group meeting, and the graphs after merging it:

image
image

@jiribenes jiribenes added the bug Something isn't working label Dec 12, 2024
@dvdvgt
Copy link
Collaborator

dvdvgt commented Dec 12, 2024

Does #732 reappear with this change?

Copy link
Collaborator

@dvdvgt dvdvgt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; #732 seems to remain fixed thanks to #741 (tested locally)

@jiribenes jiribenes merged commit 94c8851 into master Dec 12, 2024
2 checks passed
@jiribenes jiribenes deleted the revert-730-fix/inlining branch December 12, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants