Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the inferred cell type options dynamic shown or disabled in marker gene heatmap dropdown menu #465

Open
lingyun1010 opened this issue Sep 18, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@lingyun1010
Copy link
Contributor

lingyun1010 commented Sep 18, 2024

Task Details:

Currently, inferred cell type-ontology labels and inferred cell type-authors labels are always hardcoded on the front end.

But ontology labels and authors' labels don't have marker gene data for all the experiments. So, we need to make these two options dynamic in the front end.

To enable dynamic selection of these two options in the front end, we need to check the backend marker genes data for inferred cell type-ontology labels and inferred cell type-authors labels for the experiment.

If the experiment includes marker gene data for the inferred cell type-ontology labels, then please enable that option in the front end. Else disable that option.

If the experiment includes marker gene data for the inferred cell type-authors labels, then please enable that option in the front end. Else disable that option.

Backend:

  • Check marker gene data availability for the inferred cell type-ontology labels per experiment. Return boolean flag
  • Check marker gene data availability for the inferred cell type-authors labels per experiment. Return boolean flag

Front end:

  • Based on the backend boolean status for that experiment, the frontend should enable or disable inferred cell types options under the marker gene heatmap dropdown menu.
Screenshot 2024-10-09 at 16 22 02 (2)

Inferred cell type-authors labels should be disabled as we don't have marker gene data after our fix.

@upendrakumbham upendrakumbham added the bug Something isn't working label Oct 8, 2024
@ke4
Copy link
Contributor

ke4 commented Oct 8, 2024

@upendrakumbham Could you please rephrase the description of this ticket?
I am afraid I don't really understand it.
Thanks

@upendrakumbham
Copy link
Contributor

@upendrakumbham Could you please rephrase the description of this ticket? I don't understand it. Thanks

Sure, I'm going to discuss it with Silvie, and then I will update here in detail.

@upendrakumbham
Copy link
Contributor

Hi @ke4, I had a discussion with Silvie and gained clarity on the story. I updated the description box. Please review it and let me know if any further changes are needed.

@ke4
Copy link
Contributor

ke4 commented Oct 9, 2024

Thanks a lot for the change @upendrakumbham . I am happy with the updated description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants