Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The results are not appearing for some of the base experiments in bulk #171

Closed
ke4 opened this issue Jan 31, 2024 · 6 comments
Closed

The results are not appearing for some of the base experiments in bulk #171

ke4 opened this issue Jan 31, 2024 · 6 comments
Assignees
Labels
bug Something isn't working bulk

Comments

@ke4
Copy link
Contributor

ke4 commented Jan 31, 2024

Example experiment in staging: https://wwwdev.ebi.ac.uk/gxa/experiments/E-MTAB-6592/Results

Here is the error log from the JS Console:

The above error occurred in the <AnatomogramSvg> component:
    in AnatomogramSvg (created by Anatomogram)
    in div (created by Anatomogram)
    in Anatomogram (created by mapProps(Anatomogram))
    in mapProps(Anatomogram) (created by defaultProps(mapProps(Anatomogram)))
    in defaultProps(mapProps(Anatomogram)) (created by defaultProps(defaultProps(mapProps(Anatomogram))))
    in defaultProps(defaultProps(mapProps(Anatomogram))) (created by onlyUpdateForPropTypes(defaultProps(defaultProps(mapProps(Anatomogram)))))
    in onlyUpdateForPropTypes(defaultProps(defaultProps(mapProps(Anatomogram)))) (created by withPropsOnChange(onlyUpdateForPropTypes(defaultProps(defaultProps(mapProps(Anatomogram))))))
    in withPropsOnChange(onlyUpdateForPropTypes(defaultProps(defaultProps(mapProps(Anatomogram))))) (created by defaultProps(withPropsOnChange(onlyUpdateForPropTypes(defaultProps(defaultProps(mapProps(Anatomogram)))))))
    in defaultProps(withPropsOnChange(onlyUpdateForPropTypes(defaultProps(defaultProps(mapProps(Anatomogram)))))) (created by DebouncedContainer)
    in DebouncedContainer (created by _HeatmapWithControls)
    in div (created by _HeatmapWithControls)
    in div (created by _HeatmapWithControls)
    in div (created by _HeatmapWithControls)
    in _HeatmapWithControls (created by Uncontrolled(_HeatmapWithControls))
    in Uncontrolled(_HeatmapWithControls) (at uncontrollable.js:128)
    in ForwardRef (created by HeatmapWithControlsContainer)
    in HeatmapWithControlsContainer (created by ChartContainer)
    in div (created by ChartContainer)
    in div (created by ChartContainer)
    in ChartContainer (created by Container)
    in div (created by Container)
    in Container (created by ContainerLoader)
    in ContainerLoader (created by Refetch.connect(ContainerLoader))
    in Refetch.connect(ContainerLoader) (created by ExpressionAtlasHeatmap)
    in div (created by ExpressionAtlasHeatmap)
    in ExpressionAtlasHeatmap (created by Main)
    in div (created by Main)
    in div (created by Main)
    in Main (created by Context.Consumer)
    in withRouter(Main)
    in Unknown (created by Context.Consumer)
    in Route (created by ExperimentContainerRouter)
    in Switch (created by ExperimentContainerRouter)
    in div (created by ExperimentContainerRouter)
    in Router (created by BrowserRouter)
    in BrowserRouter (created by ExperimentContainerRouter)
    in ExperimentContainerRouter

Consider adding an error boundary to your tree to customize error handling behavior.
Visit https://fb.me/react-error-boundaries to learn more about error boundaries.
@ke4 ke4 assigned ke4 and lingyun1010 and unassigned ke4 Jan 31, 2024
@ke4 ke4 added bug Something isn't working bulk labels Jan 31, 2024
@ke4 ke4 assigned ke4 and unassigned lingyun1010 Feb 12, 2024
@ke4
Copy link
Contributor Author

ke4 commented Feb 12, 2024

I did some research today.
It looks like that we have a repo: atlas-experiment
that is published to npm with this name: @ebi-gene-expression-group/expression-atlas-experiment-page.
That has the ExperimentContainerRouter component.
I still have to dig deeper to find what exactly is the issue with this bug.

@ke4
Copy link
Contributor Author

ke4 commented Feb 20, 2024

The issues were the following:

  • atlas-web-core submodule were pointing to a commit that was somewhere halfway in an already merged PR (regarding to the experiment table refactor)
  • inside the package.json config file webpack was bumped to version 5.x.x and probably some dependency changes caused some other issues. Still needs to investigate this.

What I have done to enable the bulk release:

This branch of bulk was built on my local successfully with the following manual steps:

  1. Manually build the UI: ./compile-front-end-packages.sh -iu
  2. Manually build the backend: ./gradlew :app:war
  3. Use this script to startup the web app on your local environment: ./build-and-deploy-webapp.sh -n

@ke4
Copy link
Contributor Author

ke4 commented Feb 20, 2024

I also deployed the locally built WAR file into:

@ke4
Copy link
Contributor Author

ke4 commented Feb 20, 2024

Next steps:

@ke4
Copy link
Contributor Author

ke4 commented Feb 21, 2024

A compatible develop branch has been created to be able to merge the hot-fix branch (without the experiment design refactor): https://github.com/ebi-gene-expression-group/atlas-web-bulk/tree/hotfix/without_exp_design.
This is the new develop branch: adc31c6

@ke4
Copy link
Contributor Author

ke4 commented Feb 21, 2024

I have created another another ticket for the dependency update: Update bulk with the latest webpack and irs dependencies.
I am going to close this ticket as the original problem has been solved.

@ke4 ke4 closed this as completed Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working bulk
Projects
None yet
Development

No branches or pull requests

2 participants