Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Experiment page bundle refactoring #171

Open
3 tasks
ke4 opened this issue Sep 13, 2024 · 0 comments
Open
3 tasks

[Chore] Experiment page bundle refactoring #171

ke4 opened this issue Sep 13, 2024 · 0 comments
Assignees
Labels
improvement Improve/refactor existing code

Comments

@ke4
Copy link
Contributor

ke4 commented Sep 13, 2024

Most of the code that can be found under the experiment page bundle in the Single Cell Expression Atlas repository is not belongs to that repository. It should be moved to the atlas-components repository by creating 1 or more new components and creating a wrapper around that code in the single cell repository and render it.
There are 3 subtask for this story:

  • move the code from the atlas-web-single-cell repository under app/src/main/javascript/bundles/experiment-page folder to the atlas-components repository and creating 1 or more new components as it fits
  • clean the code: make it easy to maintain, testable, understandable by anyone. I added an example yesterday in Slack. (https://ebi-fg.slack.com/archives/C9P2QETJ9/p1726071369031389)
  • creating a wrapper in the single cell repository in the app/src/main/javascript/bundles/experiment-page folder around the new code and render it
@ke4 ke4 added the improvement Improve/refactor existing code label Sep 13, 2024
@lingyun1010 lingyun1010 changed the title Experiment page bundle refactoring [Chore] Experiment page bundle refactoring Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improve/refactor existing code
Projects
None yet
Development

No branches or pull requests

2 participants