-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Species filter is getting ignored in the metadata search #159
Species filter is getting ignored in the metadata search #159
Comments
During my investigation, I found that we are supporting from the backend - but we are not passing species param from the frontend I believe as per the code:
|
In the Atlas components repo - file name -
I believe we need to pass species here from the dropdown when user chooses a species along with search term |
Bugs we observed for now related to cell type wheel gene expression page:
|
Based on the previous comment by @lingyun1010 I created the following separate tickets:
and we already had this ticket: I won't delete the above comment, just to have it if we need it, but that comment does not belong to this current ticket. |
We need another PR for |
The
Species
filter in the metadata search is getting ignored.Steps to reproduce:
Search term
box. For example:liver
Search
buttonSpecies
from the dropdown, for example:Mus musculus
Expected result:
The cell type wheel only shows the result for the selected species.
Actual result:
The cell type wheel shows the result for all the species.
The above description was a bit confusing:
So, I'm adding here detailed requirements after our meeting
Use cases:
1. Gene search
Go to SCXA Home
Enter a gene ID/Symbol as a search term(pick only from gene Symbol category) and species drop-down -> any/choose species and click search
Now expected and actual are the same as we will be on the "gene-search-results" page
Endpoint: json/search
2. Metadata search
Now expected and actual is the "cell-type-wheel-experiment-heatmap" page with the cell-type wheel data
Bug
3. Metadata search
Expected is: cell type wheel should refresh only species mus musculus data + search term(liver)
Actual is: Cell type wheel data still contains multiple species data
Bug fix - The Cell type wheel should refresh based on the user search term input and species drop-down value(Input) after pressing the 'search' button
Expected and actual - Wheel data should be user-selected species data with the mentioned organism part
Note: Follow the metadata rule as I mentioned in the point 2
Endpoint navigation in the backend for points 2 and 3 is the same as I provided here:
Endpoint1- json/search -> redirects to Endpoint2
Endpoint2- /search/metadata/{term} ->Produce HTML response
Endpoint3- /json/cell-type-wheel/{searchTerm} -> Json payload
The text was updated successfully, but these errors were encountered: