Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protist getting a dangerous free ride on its version #18

Open
pcm32 opened this issue Jan 29, 2019 · 0 comments
Open

Protist getting a dangerous free ride on its version #18

pcm32 opened this issue Jan 29, 2019 · 0 comments

Comments

@pcm32
Copy link
Member

pcm32 commented Jan 29, 2019

Currently the scala code resolves the type of the organism based on string matching 'ensembl', 'wbsp', or 'genomes' on the path of the config file feed for that organism. Because our only protists organism resides inside ensembl AND ensembl version == ensembl protist version, this works out nicely for that protists.

Potential solutions:
1.- Move protist species to a 'protists' containing path, and inject the version for protists as a separate argument.
2.- Make scala code rely on the type written inside the species config file (inside annsrc), in the field 'type', and inject the version of protist as a separate argument.

In the meantime, we are safe since the two versions match, but this shouldn't be left for long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant