Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make a simple state machine to identify incorrect transitions #3660

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Make a simple state machine to identify incorrect transitions #3660

merged 3 commits into from
Dec 3, 2024

Conversation

jaceklyp
Copy link
Contributor

@jaceklyp jaceklyp commented Dec 3, 2024

Task/Issue URL: https://app.asana.com/0/0/1208878879182791/f
Tech Design URL: https://app.asana.com/0/481882893211075/1208859623176995/f
CC: @bwaresiak

Description:

  1. Implement simple state machine with empty states and AppDelegate lifecycle event triggers
  2. Fire a pixel on incorrect transition

Steps to test this PR:

  1. Duplicate any event, e.g. write appStateMachine.handle(.backgrounding(application)) twice
  2. Go to background and see the pixel m_debug_app-did-transition-to-unexpected-state is being sent

@jaceklyp jaceklyp changed the base branch from main to release/7.148.0 December 3, 2024 10:05
@jaceklyp jaceklyp requested a review from dus7 December 3, 2024 10:07
dus7
dus7 approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@dus7 dus7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dus7 dus7 merged commit 414460b into release/7.148.0 Dec 3, 2024
13 checks passed
@dus7 dus7 deleted the jacek/simple-state-machine branch December 3, 2024 10:42
samsymons added a commit that referenced this pull request Dec 3, 2024
@samsymons
Merge branch 'release/7.148.0' into sam/install-pixel
b24db75 
* release/7.148.0:
  Release 7.148.0-1 (#3661)
  Make a simple state machine to identify incorrect transitions  (#3660)
  support local storage fireproofing (#3612)
  Make NTP Grid layout adaptive for various screen sizes (#3657)
  Release 7.148.0-0 (#3659)
  Bump BSK, add Free Trials Feature Flag (#3655)
samsymons added a commit that referenced this pull request Dec 5, 2024
@samsymons
Merge branch 'main' into sam/widget-tint-color-improvement
ef73afb 
* main:
  Release 7.148.0-2 (#3676)
  Merge hotfix changes from 7.147.1 (#3674)
  Add `install` pixel (#3656)
  AI Chat browsing menu (#3635)
  Release 7.147.1-0 (#3672)
  Use actor isolation for `SubscriptionFeatureMappingCache` (#3670)
  cherry picked - already approved in #3666
  fix suggestion scrolling (#3654)
  Update autoconsent to v12.1.0 (#3650)
  Malware protection: bump BSK (#3617)
  Release 7.148.0-1 (#3661)
  Make a simple state machine to identify incorrect transitions  (#3660)
  support local storage fireproofing (#3612)
  Make NTP Grid layout adaptive for various screen sizes (#3657)
  Release 7.148.0-0 (#3659)
  Bump BSK, add Free Trials Feature Flag (#3655)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dus7 dus7 dus7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaceklyp @dus7