Make NTP Grid layout adaptive for various screen sizes #3657
+17
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dus7
force-pushed
the
mariusz/fix-ntp-grid
branch
2 times, most recently
from
78a579b to
0757ace
Compare
dus7
force-pushed
the
mariusz/fix-ntp-grid
branch
from
0757ace to
07e8bf6
Compare
brindy
approved these changes
Dec 2, 2024
samsymons
approved these changes
Dec 3, 2024
samsymons
added a commit
that referenced
this pull request
Dec 5, 2024
* main: Release 7.148.0-2 (#3676) Merge hotfix changes from 7.147.1 (#3674) Add `install` pixel (#3656) AI Chat browsing menu (#3635) Release 7.147.1-0 (#3672) Use actor isolation for `SubscriptionFeatureMappingCache` (#3670) cherry picked - already approved in #3666 fix suggestion scrolling (#3654) Update autoconsent to v12.1.0 (#3650) Malware protection: bump BSK (#3617) Release 7.148.0-1 (#3661) Make a simple state machine to identify incorrect transitions (#3660) support local storage fireproofing (#3612) Make NTP Grid layout adaptive for various screen sizes (#3657) Release 7.148.0-0 (#3659) Bump BSK, add Free Trials Feature Flag (#3655)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1206226850447395/1208868059663007/f
Tech Design URL:
CC:
Description:
Addresses NTP layout issues when it's too wide to fit 4 items. It mostly changes how the spacings and item sizes are being defined.
Steps to test this PR:
Definition of Done (Internal Only):
Orientation Testing:
Device Testing:
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template