-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for GCP PubSub and Google Spanner database #1154
base: master
Are you sure you want to change the base?
Conversation
Hello, As far as I know, Pub/Sub does not support multiple topics attached to one subscription, so we can't provide support for CAP group, Are you try to solve this? |
yes, Pub/Sub does not support multiple topics to one subscription. CAP group would not be supported but we can work without that. |
Since this is a core feature, it would be difficult for us to merge it into our main repository without support group feature, I would suggest that this could be written into our docs as a community supported extension and you as the maintainer, what do you think? Community supported list docs: Thank you. |
I Yang, Google Pub/Sub would never support subscription group but that doesn't mean CAP cannot support GCP Pub/Sub. What Google recommends is to have only one subscription per Topic. |
Any thoughts on merging this pull request to master? |
1c79b60
to
406590f
Compare
… handled by existing projects
/// </summary> | ||
/// <param name="options">CAP configuration options</param> | ||
/// <param name="projectId">The GCP <c>Project</c> ID.</param> | ||
public static CapOptions UseGooglePubSub(this CapOptions options,string projectId) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public static CapOptions UseGooglePubSub(this CapOptions options,string projectId) | |
public static CapOptions UseGooglePubSub(this CapOptions options, string projectId) |
Extended the code and added support for GCP Pub/sub (message broker) and Google Spanner database.
Added a sample application "Sample.GcpPubSub.GoogleSpanner" to validate the changes. Open appsettings.json of "Sample.GcpPubSub.GoogleSpanner" and change the PubSub details and also change the spanner connection string to try out the changes.