Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/26633 grid layout manager #26641

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

maonaoda
Copy link
Contributor

Description of Change

When calculating the width and height of the cell, add space to prevent using the wrong view size to calculate the platform size.

iOS:

Before fix After fix

Android:

Before fix After fix

maccatalyst:

Before fix After fix

Issues Fixed

Fixes #26633

@maonaoda maonaoda requested review from jfversluis, jsuarezruiz and a team as code owners December 15, 2024 06:47
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Dec 15, 2024
Copy link
Contributor

Hey there @maonaoda! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@jfversluis
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@maonaoda
Copy link
Contributor Author

Should I compare the heights of the Labels directly, or use DeviceTest instead of UITest?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community ✨ Community Contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS/maccatalyst/Android] Label height in Grid with ColumnSpacing > 0 incorrect in certain cases
2 participants