Change iOS SetNeedsLayout propagation mechanism #26629
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albyrock87
requested review from
jfversluis,
jsuarezruiz and
a team
as code owners
|
Hey there @albyrock87! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
MartyIX
reviewed
Dec 14, 2024
| @@ -147,7 +147,10 @@ await CreateHandlerAndAddToWindow<CarouselViewHandler>(carouselView, async (hand | |||
| Assert.False(data.IsCollectionChangedEventEmpty); | |||
| }); | |||
|
|
|||
| carouselView.Handler?.DisconnectHandler(); | |||
| await InvokeOnMainThreadAsync(() => | |||
There was a problem hiding this comment.
I wonder if this change could be a separate PR. I suppose that DisconnectHandler should always run on the main thread (or not?).
There was a problem hiding this comment.
This is just a device test which randomly fails due to the fact it may run on a background thread. I came across it and it was a quick fix to do.
There was a problem hiding this comment.
So that's a great PR-stuff actually.
(In fact, if there is a way to detect it, it might probably fix a class of bugs.)
albyrock87
force-pushed
the
ios-set-neesd-layout-propagation-mapper
branch
from
2ad0ab2 to
5b5e4b9
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
I've been asked to split #25664 into separate PR.
This is the first piece which aims to change the way we propagate
SetNeedsLayoutby doing that only when MAUI commands.As seen in the linked issue, there are situations where iOS triggers
SetNeedsLayoutnatively and we don't want to propagate those.This enables us to receive a
SetNeedsLayoutinTemplatedCellwhich will allow us to resize the cell without relaying onMeasureInvalidatedcross platform event propagation.There will be a follow-up PR to tackle this.
Issues Fixed
Fixes #24996