[iOS] Inherit UIContainerView from MauiView #26576
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubaflo
changed the title
kubaflo
force-pushed
the
general-wrapper-view-containeruiview
branch
from
8136e66 to
7caf77c
Compare
kubaflo
force-pushed
the
general-wrapper-view-containeruiview
branch
from
7caf77c to
561fffa
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This was referenced Dec 13, 2024
jfversluis
added
the
area-architecture
|
/rebase |
github-actions
bot
force-pushed
the
general-wrapper-view-containeruiview
branch
from
e18505c to
df66359
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
requested changes
Dec 13, 2024
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/UIContainerView.cs:70
- Ensure that the new 'UpdateSize' method is covered by tests to verify its behavior.
internal CGSize UpdateSize(CGSize size)
df66359 to
46d3315
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To inherit
UIContainerViewfromGeneralWrapperView,GeneralWrapperViewneeds to be public, so if these changes are okay then I will modify the public API perhapsThis would close this one: #26456
I've added an internal method
UpdateSizetoUiContainerView, because SizeThatFits should not affect the size of a view which currently happens@rmarinho @PureWeen