Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Enable source index #26557

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[ci] Enable source index #26557

wants to merge 2 commits into from

Conversation

rmarinho
Copy link
Member

@rmarinho rmarinho commented Dec 11, 2024

Description of Change

Make our internal build on dnceng and arcade push to source.dot.net

After merging on our side we need to wait for the merge of this one dotnet/source-indexer#178

Issues Fixed

Fixes #6814

fix variables

Update azure-pipelines-internal.yml

Update NuGet.config

try pass this one

Update NuGet.config

enable source index

Update build-test-pack.yml

Update build-test-pack.yml

try enable source index

try this again

no warn and bin log

try fix binlog
@rmarinho rmarinho requested a review from a team as a code owner December 11, 2024 22:51
@rmarinho rmarinho added area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions t/docs 📝 labels Dec 11, 2024
@rmarinho rmarinho added this to the .NET 9 SR3 milestone Dec 11, 2024
enableSourceIndex: false
enableSourceIndex: ${{ parameters.enableSourceIndex }}
sourceIndexParams:
sourceIndexBuildCommand: build.cmd -restore -build -ci -warnAsError 0 /bl:$(Build.Arcade.LogsPath)sourceIndexBuild.binlog /p:OfficialBuildId=$(_BuildOfficalId) /p:_SkipUpdateBuildNumber=true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mixes - and /, do you want to pick one to be consistent?

Comment on lines +18 to +19
<!-- Added manually for .NET 8.0.12 -->
<add key="darc-pub-dotnet-runtime-c1ae9626" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-runtime-c1ae9626/nuget/v3/index.json" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What needed this feed? The build.cmd below?

Does it use the system-installed .NET on the CI machine or something else?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the build.cmd by default will use the existing dotnet if it exists but I don t really want that for now. So I bumped do t make it fix our build here:

https://dev.azure.com/dnceng/internal/_build/results?buildId=2599947&view=results

Comment on lines 2 to +3
"tools": {
"dotnet": "9.0.100"
"dotnet": "9.0.102-servicing.24577.25"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this why the feed is required above? Could you just use 9.0.101 that just came out?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yap, kinda of, right now the setup I have it needs to provision a new dotnet, if the global dotnet matches my script fails, I need to fix that. thats why I bumped this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is main, was the policy to only use stable/released bits? Like 9.0.101?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only used by our internal setup on dnceng and builds with arcade. For a developer suing cake shouldn't t make a difference. the version for the sdk on the version props is still 9.0.100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions t/docs 📝
Projects
Status: Ready To Review
Development

Successfully merging this pull request may close these issues.

Onboard to source.dot.net
2 participants