[Windows] Fix Shell animation and button visual states on Shell nav #26521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 10, 2024 11:30
* Clear previous page content presenter on unload to prevent brief visual flash
Foda
requested review from
jfversluis,
jsuarezruiz and
a team
as code owners
PureWeen
requested changes
Dec 13, 2024
| @@ -9,6 +9,7 @@ public partial class ButtonHandler : ViewHandler<IButton, Button> | |||
| { | |||
| PointerEventHandler? _pointerPressedHandler; | |||
| PointerEventHandler? _pointerReleasedHandler; | |||
| bool _isPressed; | |||
There was a problem hiding this comment.
Do we need to apply this to ImageButton as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix the Shell navigation to other page visual glitch, and ensure that the released mouse event triggers on buttons that are pressed and then unloaded
Issues Fixed
Fixes #26466 #26432