[release/8.0] Fix Kestrel host header mismatch handling when port in Url #59403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrennanConroy
added
the
area-networking
BrennanConroy
requested review from
halter73,
JamesNK and
mgravell
as code owners
BrennanConroy
added
ask-mode
Open
3 tasks
BrennanConroy
added
Servicing-approved
|
Hi @BrennanConroy. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #59352
Fix Kestrel host header mismatch handling when port in Url
Description
Fixes some validation of host headers in Kestrel if a non-default port is included in the request url.
Customer Impact
Valid requests will result in a 400 error response if they hit this case.
An internal partner team is hitting this currently.
Regression?
Risk
Small bug fix with additional unit test coverage to make sure it works and doesn't regress in the future.
Verification
Packaging changes reviewed?