Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: adding pr validator for fork prs as gh command will not work #6143

Merged
merged 11 commits into from
Nov 29, 2024
Merged

misc: adding pr validator for fork prs as gh command will not work #6143

merged 11 commits into from
Nov 29, 2024

Conversation

badal773
Copy link
Contributor

Description

Fixes #

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@badal773 badal773 changed the title misc: pr validator for fork prs misc: adding pr validator for fork prs as gh command will not work Nov 29, 2024
tayalrishabh96
tayalrishabh96 reviewed Nov 29, 2024
View reviewed changes
Copy link
Contributor

@tayalrishabh96 tayalrishabh96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add below permission as well
repository-projects: read

pawan-mehta-dt
pawan-mehta-dt previously approved these changes Nov 29, 2024
View reviewed changes
tayalrishabh96
tayalrishabh96 previously approved these changes Nov 29, 2024
View reviewed changes
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@badal773 badal773 merged commit 632f20c into main Nov 29, 2024
8 checks passed
@badal773 badal773 deleted the fix-pr-validator-for-fork-prs branch November 29, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tayalrishabh96 tayalrishabh96 tayalrishabh96 approved these changes

@pawan-mehta-dt pawan-mehta-dt pawan-mehta-dt approved these changes

@prakarsh-dt prakarsh-dt Awaiting requested review from prakarsh-dt prakarsh-dt is a code owner

@nishant-d nishant-d Awaiting requested review from nishant-d nishant-d is a code owner

@vikramdevtron vikramdevtron Awaiting requested review from vikramdevtron vikramdevtron is a code owner

Assignees
No one assigned
Labels
PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@badal773 @pawan-mehta-dt @tayalrishabh96