Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Secret masking fix #6136

Merged
merged 24 commits into from
Dec 9, 2024
Merged

fix: Secret masking fix #6136

merged 24 commits into from
Dec 9, 2024

Conversation

prakash100198
Copy link
Contributor

@prakash100198 prakash100198 commented Nov 27, 2024 •
edited
Loading

Description

This pr corresponds to the issue when a view only user is able to see the secrets (base64 encoded) in the api config/data, which serves at appConfiguration page, deployment history page and cd roll back page.
Fixes https://github.com/devtron-labs/sprint-tasks/issues/1256

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@prakash100198
add omitempty with json key Index in DeploymentAndCmCsConfigDto
b391b00
@prakash100198
some refact after code review -1
bcfd4e7
@prakash100198
Merge branch 'develop' into secret-masking-fix
a940803
@prakash100198
take in query param ComparisonRequestDto instead of payload in get req
be86fd0
@prakash100198
Merge branch 'develop' into secret-masking-fix
7a2ca72
@prakash100198
envName and appName in comparisonItems
740c3ae
@prakash100198
support wfrid in case of previous deployments as config type
b5008f3
@prakash100198
bug fix
e5a6a00
@prakash100198
Merge branch 'develop' into secret-masking-fix
9778130
@prakash100198
dev test fix:- instead of checking on global field in secret config d…
22cd18a 
…ata while unmarshalling leverage data and defaultData fields
@prakash100198
first depl fix
e3ae3a0
@prakash100198
mask secret in case of view only when request is for only one secret
457febe
@prakash100198
code review
d3ad04a
@prakash100198
Merge branch 'develop' into secret-masking-fix
7aaa013
iamayushm
iamayushm previously approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@iamayushm iamayushm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed in enterprise

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 9, 2024

Quality Gate Passed Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@prakash100198 prakash100198 merged commit c93ad53 into develop Dec 9, 2024
7 of 8 checks passed
@prakash100198 prakash100198 deleted the secret-masking-fix branch December 9, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikramdevtron vikramdevtron vikramdevtron approved these changes

@iamayushm iamayushm iamayushm approved these changes

@nishant-d nishant-d Awaiting requested review from nishant-d nishant-d is a code owner

@prakarsh-dt prakarsh-dt Awaiting requested review from prakarsh-dt prakarsh-dt is a code owner

@vivek-devtron vivek-devtron Awaiting requested review from vivek-devtron vivek-devtron is a code owner

Assignees
No one assigned
Labels
PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prakash100198 @iamayushm @vikramdevtron