Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: node k8s permissions #6123

Merged
merged 15 commits into from
Nov 28, 2024
Merged

feat: node k8s permissions #6123

merged 15 commits into from
Nov 28, 2024

Conversation

Shivam-nagar23
Copy link
Member

@Shivam-nagar23 Shivam-nagar23 commented Nov 25, 2024

Description

Fixes #https://github.com/orgs/devtron-labs/projects/7/views/1?pane=issue&itemId=87919806&issue=devtron-labs%7Csprint-tasks%7C1310

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


gireesh-naidu
gireesh-naidu previously approved these changes Nov 25, 2024
Copy link
Member

@gireesh-naidu gireesh-naidu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, checked it in ent PR

@Shivam-nagar23 Shivam-nagar23 changed the title Feat k8s permissions feat: feat k8s permissions Nov 26, 2024
@Shivam-nagar23 Shivam-nagar23 changed the title feat: feat k8s permissions feat: node k8s permissions Nov 26, 2024
Copy link

sonarcloud bot commented Nov 27, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
18.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@Shivam-nagar23 Shivam-nagar23 merged commit 1ccca6c into develop Nov 28, 2024
6 of 11 checks passed
@Shivam-nagar23 Shivam-nagar23 deleted the feat-k8s-permissions branch November 28, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants