Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: remove environment null check while getting chart via repo url #6061

Merged
merged 6 commits into from
Nov 11, 2024
Merged

misc: remove environment null check while getting chart via repo url #6061

merged 6 commits into from
Nov 11, 2024

Conversation

ayu-devtron
Copy link
Contributor

@ayu-devtron ayu-devtron commented Nov 7, 2024 •
edited
Loading

Description

Fixes https://github.com/devtron-labs/devops-sprint/issues/1223

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

iamayushm
iamayushm previously approved these changes Nov 8, 2024
View reviewed changes
iamayushm
iamayushm reviewed Nov 8, 2024
View reviewed changes
Copy link
Contributor

@iamayushm iamayushm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please review app status cache update flow

@ayu-devtron
remove UpdateDeploymentStatusAndCheckIsSucceeded in favour of impl.ap…
8ea7041 
…pService.UpdateDeploymentStatusForGitOpsPipelines
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@vikramdevtron vikramdevtron changed the title fix: remove environment null check while getting chart via repo url chore: remove environment null check while getting chart via repo url Nov 11, 2024
@tayalrishabh96 tayalrishabh96 changed the title chore: remove environment null check while getting chart via repo url misc: remove environment null check while getting chart via repo url Nov 11, 2024
@ayu-devtron ayu-devtron merged commit 8ab82be into main Nov 11, 2024
15 of 22 checks passed
@ayu-devtron ayu-devtron deleted the delay-deployment-fix branch November 11, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamayushm iamayushm iamayushm left review comments

@Shivam-nagar23 Shivam-nagar23 Shivam-nagar23 approved these changes

@vivek-devtron vivek-devtron vivek-devtron approved these changes

@vikramdevtron vikramdevtron vikramdevtron approved these changes

@prakash100198 prakash100198 prakash100198 approved these changes

@nishant-d nishant-d Awaiting requested review from nishant-d nishant-d is a code owner

@prakarsh-dt prakarsh-dt Awaiting requested review from prakarsh-dt prakarsh-dt is a code owner

Assignees
No one assigned
Labels
PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ayu-devtron @iamayushm @prakash100198 @vikramdevtron @vivek-devtron @Shivam-nagar23