Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Read service for DeploymentTemplateHistoryService and ConfigMapHistoryService #6041

Merged
merged 9 commits into from
Nov 11, 2024
Merged

chore: Read service for DeploymentTemplateHistoryService and ConfigMapHistoryService #6041

merged 9 commits into from
Nov 11, 2024

Conversation

prakash100198
Copy link
Contributor

@prakash100198 prakash100198 commented Oct 29, 2024 •
edited
Loading

Description

Fixes #

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@prakash100198 prakash100198 changed the base branch from main to develop October 29, 2024 11:31
@prakash100198 prakash100198 changed the title chore: introduce deploymenttemplatehistoryreadservice with a bunch of refact… chore: Read service for DeploymentTemplateHistoryService Oct 29, 2024
@prakash100198
adaptor for HistoryDetailDto
996c01c
@prakash100198
extract out wire set for all history config in wire_history.go
fadf726
@prakash100198
move deploymenttemplateservice.go to pkg/deployment/manifest/deployme…
2d76713 
…ntTemplate as it makes sense for all depl template service layer methods to be at one place , this is part one of such refactoring
@prakash100198
move deploymenttemplateservice.go to pkg/deployment/manifest/deployme…
d0cc221 
…ntTemplate as it makes sense for all depl template service layer methods to be at one place , this is part one of such refactoring
@prakash100198
move ConfigMapHistoryService.go to deployment/manifest/configMapAndSe…
cecc228 
…cret repo
@prakash100198
fill ConfigMapHistoryReadService.go interface with methods extracted …
e70b366 
…out from ConfigMapHistoryService.go
@prakash100198
remove userService from configmapreadservice
2461776
@prakash100198 prakash100198 changed the title chore: Read service for DeploymentTemplateHistoryService chore: Read service for DeploymentTemplateHistoryService and ConfigMapHistoryService Oct 29, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 11, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
5.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@prakash100198 prakash100198 merged commit 06e4c5d into develop Nov 11, 2024
3 of 4 checks passed
@prakash100198 prakash100198 deleted the read-service-depl-history branch November 11, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikramdevtron vikramdevtron vikramdevtron approved these changes

@iamayushm iamayushm iamayushm approved these changes

@nishant-d nishant-d Awaiting requested review from nishant-d nishant-d is a code owner

@prakarsh-dt prakarsh-dt Awaiting requested review from prakarsh-dt prakarsh-dt is a code owner

Assignees
No one assigned
Labels
PR:Issue-verification-failed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prakash100198 @iamayushm @vikramdevtron