Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix the incorrect parameter order #5918

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

fix: Fix the incorrect parameter order #5918

wants to merge 3 commits into from

Conversation

cuishuang
Copy link

Description

Fix the incorrect parameter order

Fixes #

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

iamayushm and others added 2 commits September 26, 2024 14:05
@iamayushm
fix: app update migration (devtron-labs#5903)
e5beefe 
* wip: adding app name check

* wip

* wip

* wip

* moving migration to code

* wip: adding app name in log

* wip: moving sql logic to code

* pg no rows handling

* adding db migration call

* fixing fetch app query

* wip: adding pg multiple rows handling

* audit log update
@cuishuang
Fix the incorrect parameter order
94899a2 
Signed-off-by: cuishuang <[email protected]>
@ayu-devtron
Copy link
Contributor

Hi @cuishuang , can you please change the target branch to develop ? We are in transition to manage releases from develop branch

@cuishuang cuishuang changed the base branch from main to develop September 30, 2024 17:17
@cuishuang
Copy link
Author

Hi @cuishuang , can you please change the target branch to develop ? We are in transition to manage releases from develop branch

Modified. Please review again.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ayu-devtron
Copy link
Contributor

Thanks @cuishuang. We will consider this as part of next release

@cuishuang
Copy link
Author

Thanks @cuishuang. We will consider this as part of next release

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikramdevtron vikramdevtron Awaiting requested review from vikramdevtron vikramdevtron is a code owner

@kripanshdevtron kripanshdevtron Awaiting requested review from kripanshdevtron

@nishant-d nishant-d Awaiting requested review from nishant-d nishant-d is a code owner

@prakarsh-dt prakarsh-dt Awaiting requested review from prakarsh-dt prakarsh-dt is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cuishuang @ayu-devtron @iamayushm