Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.ajaxSetup predefines all parameters #210

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Calamari
Copy link

If you have to set some custom headers on every request like CSRF tokens, it is tedious to specify them on every request. Allow .ajaxSetup to predefined them once, so they are used in every request.

@joaocunha
Copy link

+1, specially for CSRF tokens. I'm currently experiencing this issue.

@ded is this something you'd be interested in adding?

@ded
Copy link
Owner

ded commented Oct 20, 2015

this is a good change and I definitely welcome it. At this moment the pull request is conflicting. Would you mind confining your commits to just src/reqwest.js and the README file? I can run the builds when appropriate.

@Calamari
Copy link
Author

Done. I reduced the amount of changed files now. And rebased to current master, just to be on the safe side.

@danbovey
Copy link

+1

@joaocunha
Copy link

@ded xmas ping! :)

@calcsam
Copy link

calcsam commented May 4, 2016

We've monkey-patched our version of reqwest (@plangrid) to incorporate this change. Any chance it gets merged into the official version? @ded :)

@nilliams
Copy link

nilliams commented Aug 2, 2016

Just hit this today (for CSRF) and would also love to see this merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants