-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Broken Tilde and Grave (Backtick/Backquote) (regression bugfix) #1711
base: master
Are you sure you want to change the base?
Conversation
Thanks for doing this - looking forward to having it finally fixed! Here's a direct link to the PR (the description has a typo as I write this): |
Anyone know how to ping the maintainers? Does a comment like this do it? I've gotten several requests for binaries (x86_64) for other systems besides the one I created (arm64) in my fork, and it would be way more convenient to just have this fixed in Barrier instead of my fork. |
@p12tic @walker0643 Anyone still around that can merge pull requests? This broken tilde key is extra painful. |
@dgentry Any chance you've built an M1 Ventura binary? If not, would this project be hard to set up and build for someone with plenty of Windows and web development experience but no Mac experience? |
I built this for Ventura, working great so far- I don't have a ton of experience in building on macOS, but I imagine you'll have to follow the code signing steps outlined here - #960 (comment) Basically just copy it into your Applications folder and then- |
Awesome thanks so much @ktonini. Love the Mitch Hedberg reference in your bio! Legend. |
Some maintainers (@p12tic and @shymega) left for their own fork (input-leap/input-leap#1414). You could try a PR there? |
Yes, open a PR on Input Leap, and we'll review it. Thanks. |
@dgentry will this build work on Intel macs as well? Thanks for the support! |
This was copied from debauchee/barrier#1711 by @dgentry
This was copied from debauchee/barrier#1711 by @dgentry. Resolves input-leap#1541 and input-leap#1407. Signed-off-by: Dom Rodriguez <[email protected]>
Just wanted to say thanks. Built your branch tonight and almost wept typing |
I'm just now seeing this, but builds did work on Intel/Mojave. I no longer have an Intel Mac, but I could borrow one from a friend if you are still interested in a binary. It seems unlikely that this PR will ever go in to debauchee/barrier, but if this isn't already fixed in Input Leap, I'm happy to make a PR there too. |
Ha! I didn't remember that someone adapted this PR for Input Leap already. input-leap/input-leap#1668 So you might just switch from Barrier to Input Leap. I'll give it a try now. |
FYI, this also works for me on MacOS Sonoma 14.4 as the Barrier server and with a NixOS client. 🎉 Also the MacOS release has been built by the azure CI pipeline and is available: the release artifacts can be downloaded from the AzureDevops website. |
I'm unable to download any of these releases/artifacts, is there anything specific I need to do to access the links? I see the list but when I click on any of those nothing happens. |
Wow, what a terrible UI. You can use the kabob menu on the right to download. |
This is nearly a duplicate PR to vladimirlagunov's PR #1541, which seems to have stalled. This PR doesn't have Azure attempt to build for MacOS 10.14, because Azure removed the MacOS 10.14 image in Dec 2021. This PR fixes #1531 and #1407.
This regression was introduced in PR #1214 and broke tilde (~) and grave/backtick/backquote (`) on MacOS Barrier servers.
If the author of the regression-introducing PR (1241) wants to enable tilde and grave as modifier keys on JIS keyboards, it would be possible in a non-breaking way by checking for the keyboard type before adding these as modifier keys.
Contributor Checklist:
doc/newsfragments
directory IF it is auser-visible change (and make sure to read the
README.md
in that directory)