Add test to validate resizing of animated image. #443
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found the original PR that added the 0.5. This change breaks the test that one had so I'm going to do some research on why. The scale without casting to int results in 99.84 on the test previously. See #386 |
|
Thanks @TheKigen. This bug has been haunting a bit too long. Greatly appreciated if you can look into it. Let me know when the PR is ready to review and merge |
|
Hey @TheKigen I would love it if you could look at helping finalize this PR. Do you have any time in the near future to look at this? |
|
Hi, @tonimelisma just been busy with a work trip this week. I'll try to get something done on it the weekend of Oct 5th. |
|
Hey @TheKigen - thanks for the input. I eagerly await your contributions. Thanks again for helping! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test to the ImageRef.Resize functions to make sure when resizing an animated image that the correct scale is used to avoid unrolling the animated image.
See #350