write icc files to tmp only when necessary #442
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @code1super and apologies for the delay, I've been traveling overseas. Could you write tests for the changes please? The PR is greatly appreciated! |
|
Hey @code1super I love the PR but could you add the tests? |
|
@tonimelisma @code1super I just created #456 which contains @code1super's original commits plus adjustments to the test. I hope that's fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see no reason to write these files to a temporary file when it is not consumed.
It can make unnecessary errors when there is no have temporary folder or when there is no disk space or when there are no write permissions.