Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle 7 #763

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Gradle 7 #763

wants to merge 24 commits into from

Conversation

nrbrook
Copy link
Contributor

@nrbrook nrbrook commented Aug 14, 2021

I had a go at switching to gradle 7.

One issue is Maven publishing. I switched to the maven-publish plugin, but not sure I can test it. I wasn't sure how to handle non-android libraries either so I excluded for now. Perhaps a starting point though.

Some unit tests fail. When running the tests in Android studio, I get a lot of java.lang.reflect.InvocationTargetException in ElectricSputnik, but this doesn't occur when running in the GitHub action. I'm not sure what the difference is, any ideas?

Otherwise, the sample App builds and runs fine.

@nrbrook
Copy link
Contributor Author

nrbrook commented Nov 13, 2021

After merging the unit tests without robolectric, all tests are passing now. The only remaining work to do is testing maven publish which I don't think I can do.

@nrbrook
Copy link
Contributor Author

nrbrook commented Mar 3, 2022

@dariuszseweryn Building javadocs currently doesn't work because of relocated javax.inject:

javadoc: error - In doclet class com.google.doclava.Doclava,  method start has thrown an exception java.lang.reflect.InvocationTargetException
com.sun.tools.javac.code.Symbol$CompletionFailure: class file for bleshadow.javax.inject.Inject not found

I upgraded the shadow plugin but still get the same error. Any ideas?

@nrbrook
Copy link
Contributor Author

nrbrook commented Mar 26, 2022

@dariuszseweryn I decided to fork this project so we can maintain it more actively and merge the PRs we had open. I've forked at https://github.com/NRB-Tech/RxAndroidBle/ and it's on Maven Central as io.nrbtech.rxandroidble. I've merged this PR there. If you continue maintaining this project, you may want to look at the following files for up to date publishing to Maven Central via GitHub Action:
https://github.com/NRB-Tech/RxAndroidBle/blob/main/gradle/gradle-mvn-push.gradle
https://github.com/NRB-Tech/RxAndroidBle/blob/main/gradle/gradle-mvn-config.gradle
https://github.com/NRB-Tech/RxAndroidBle/blob/main/.github/workflows/publish.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant