-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Support API 31 (Android 12) new Bluetooth permissions #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @dariuszseweryn, thanks for working on this! |
Hi, I was on long vacations. I am trying to maintain only the RxAndroidBle. Other mentioned libs were transferred to a different entity... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API 31 introduces new Bluetooth permissions required for BLE operations. In the context of RxAndroidBle the important ones are:
BLUETOOTH_SCAN
— replaces previously needed ACCESS_FINE_LOCATIONBLUETOOTH_CONNECT
— a new conceptConsiderations:
The library's AndroidManifest.xml does include
ACCESS_COARSE_LOCATION
andACCESS_FINE_LOCATION
since API 23. Technically these could be restricted tomaxSdkVersion="30"
but it could be a breaking change for apps that require location access otherwise. There is a new example in the Readme if the user does not want to require location access for other reasons than scanning BLE peripherals.TODO:
BLUETOOTH_SCAN
makes Location Services requirement obsoleteResult: If the user sets flag
neverForLocation
then Location Services are not needed. Otherwise they still are needed to get scan results.Add check for newExpected to be a thrown exception anywayBLUETOOTH_CONNECT
permission?Design newExtracted to Create new API for getting state of RxBleClient #764RxBleClient#State
API for convenient usage with the new permission modelResolves #752