Fix and clean commentary

dariuszseweryn · Jul 2, 2018 · 1513722 · 1513722
1 parent 6f5b8fb
commit 1513722
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 16 deletions.
diff --git a/rxandroidble/src/main/java/com/polidea/rxandroidble2/RxBleConnection.java b/rxandroidble/src/main/java/com/polidea/rxandroidble2/RxBleConnection.java
@@ -275,8 +275,12 @@ interface WriteOperationAckStrategy extends ObservableTransformer<Boolean, Boole
      *
      * Timeouts after specified amount of time.
      *
+     * The cache can be cleared to perform a new Gatt Discover and maybe find a service previously hidden
+     *
      * @param timeout multiplier of TimeUnit after which the discovery will timeout in case of no return values
      * @param timeUnit TimeUnit for the timeout
+     * @param clearCache Flag to ask the cache clearing (Warning, this functionnality can alter the good working of your app
+     *                   You should have strong knowledge of how it works)
      * @return Observable emitting result a GATT service discovery.
      * @throws BleGattCannotStartException with {@link BleGattOperationType#SERVICE_DISCOVERY} type, when it wasn't possible to start
      *                                     the discovery for internal reasons.

diff --git a/.../src/main/java/com/polidea/rxandroidble2/internal/connection/ServiceDiscoveryManager.java b/.../src/main/java/com/polidea/rxandroidble2/internal/connection/ServiceDiscoveryManager.java
@@ -47,28 +47,31 @@ class ServiceDiscoveryManager {
     }
 
     Single<RxBleDeviceServices> getDiscoverServicesSingle(final long timeout, final TimeUnit timeoutTimeUnit) {
-        if (hasCachedResults) {
-            // optimisation to decrease the number of allocations
-            return deviceServicesObservable;
-        } else {
-            return deviceServicesObservable.doOnSubscribe(
-                    new Consumer<Disposable>() {
-                        @Override
-                        public void accept(Disposable disposable) throws Exception {
-                            timeoutBehaviorSubject.onNext(new TimeoutConfiguration(timeout, timeoutTimeUnit, Schedulers.computation()));
-                        }
-                    });
-        }
+        return getDiscoverServicesSingle(timeout, timeoutTimeUnit, false);
     }
 
     Single<RxBleDeviceServices> getDiscoverServicesSingle(final long timeout, final TimeUnit timeoutTimeUnit, Boolean clearCache) {
-        if (hasCachedResults) {
+        if (clearCache) {
+            hasCachedResults = false;
+            this.deviceServicesObservable = getTimeoutConfiguration().flatMap(scheduleActualDiscoveryWithTimeout())
+                    .doOnSuccess(Functions.actionConsumer(new Action() {
+                        @Override
+                        public void run() throws Exception {
+                            hasCachedResults = true;
+                        }
+                    }))
+                    .doOnError(Functions.actionConsumer(new Action() {
+                        @Override
+                        public void run() {
+                            reset();
+                        }
+                    }))
+                    .cache();
+        }
+        if (hasCachedResults && !clearCache) {
             // optimisation to decrease the number of allocations
             return deviceServicesObservable;
         } else {
-            if (clearCache) {
-                reset();
-            }
             return deviceServicesObservable.doOnSubscribe(
                     new Consumer<Disposable>() {
                         @Override