AssetSpec in module load #26476
Draft
AssetSpec in module load #26476
+126
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+545
to
+550
| automation_condition=automation_condition | ||
| if automation_condition is None and automation_condition | ||
| else ..., | ||
| freshness_policy=freshness_policy | ||
| if freshness_policy is None and freshness_policy | ||
| else ..., |
There was a problem hiding this comment.
The conditions if automation_condition is None and automation_condition and if freshness_policy is None and freshness_policy are logically impossible to satisfy, as they require the values to be both None and truthy simultaneously. These conditions should be changed to if automation_condition is not None and if freshness_policy is not None respectively to properly apply these attributes when they are provided.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
How I Tested These Changes
Changelog