Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don’t require —standard-libraries matches across doo files #5971

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

robin-aws
Copy link
Member

What was changed?

--standard-libraries is registered as an option that has to match when consuming a doo file, but this is incorrect because passing it again leads to duplicate definitions.

How has this been tested?

useStandardLibraries.dfy

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

Copy link
Member

@keyboardDrummer keyboardDrummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OptionLibraryImpliesLocalError seems correct to me. The standard library should never be included in a generated .doo file.

I think I started a PR to add separate compilation support to the standard library some time ago: #4877

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants