fix: Regenerate system module in DafnyRuntimeGo-gomod, add missing CI check #5965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robin-aws
changed the title
alex-chew
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we split off the separate
DafnyRuntimeGo-gomodcopy of the Go runtime, we neglected to duplicate the CI mechanism we have in each runtime that ensures the generatedSystemmodule matches what Dafny is currently generating. As a result this copy was missing theCompanionStruct_Nat_.Is_function Dafny now generates for subset types likenat.How has this been tested?
Updated
runtime-tests.yml.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.