Symfony 4 compatiblity (#8)

* Symfony 4 compatiblity * "ovh" service is now explicitely public. * Added an alias to Ovh\Api for autowiring. * Fix tests
coopTilleuls · Jun 21, 2018 · 0cdf311 · 0cdf311
1 parent 5c88dea
commit 0cdf311
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/Resources/config/services.xml b/Resources/config/services.xml
@@ -12,7 +12,8 @@
             <argument>%coop_tilleuls_ovh.consumer_key%</argument>
         </service>
 
-        <service id="ovh" alias="coop_tilleuls_ovh.api" />
+        <service id="ovh" alias="coop_tilleuls_ovh.api" public="true" />
+        <service id="Ovh\Api" alias="coop_tilleuls_ovh.api" />
     </services>
 
 </container>
diff --git a/composer.json b/composer.json
@@ -14,9 +14,9 @@
     ],
     "require": {
         "php": ">=5.5",
-        "symfony/dependency-injection" : "~2.3|~3.0",
-        "symfony/config" : "~2.3|~3.0",
-        "symfony/http-kernel": "~2.3|~3.0",
+        "symfony/dependency-injection" : "~2.3|~3.0|~4.0",
+        "symfony/config" : "~2.3|~3.0|~4.0",
+        "symfony/http-kernel": "~2.3|~3.0|~4.0",
         "ovh/ovh": "~2.0"
     },
     "autoload": {

diff --git a/spec/CoopTilleuls/OvhBundle/DependencyInjection/CoopTilleulsOvhExtensionSpec.php b/spec/CoopTilleuls/OvhBundle/DependencyInjection/CoopTilleulsOvhExtensionSpec.php
@@ -44,6 +44,7 @@ function it_loads(ContainerBuilder $container)
         $container->hasExtension('http://symfony.com/schema/dic/services')->shouldBeCalled();
         $container->setDefinition('coop_tilleuls_ovh.api', Argument::type('Symfony\Component\DependencyInjection\Definition'))->shouldBeCalled();
         $container->setAlias('ovh', Argument::type('Symfony\Component\DependencyInjection\Alias'))->shouldBeCalled();
+        $container->setAlias('Ovh\Api', Argument::type('Symfony\Component\DependencyInjection\Alias'))->shouldBeCalled();
 
         $configs = array(
             array(