Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @guillaumebernard84 as an fr approver #2370

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

sestegra
Copy link
Collaborator

Describe your changes

In recognition of @guillaumebernard84's dedicated contributions to the French localization team, this PR elevates him to the role of approver.

Related issue number or link (ex: resolves #issue-number)

N/A

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

Signed-off-by: Stéphane Este-Gracias <[email protected]>
@sestegra sestegra added the maintainers Use this label if PR requires maintainers to take action label Sep 10, 2023
@netlify
Copy link

netlify bot commented Sep 10, 2023

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 120f432
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/64fda82457100c00082a5348
😎 Deploy Preview https://deploy-preview-2370--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@huats huats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is well deserved !

@seokho-son
Copy link
Collaborator

Hi @guillaumebernard84,
Thank you for your valuable contributions to the French localization so far!
Please review the Policy for Localization Approvers (Pending Candidate Confirmation) #723. After review it, please leave a comment on this PR to confirm that you've read and understood the policy. :)

@seokho-son
Copy link
Collaborator

Hi @sestegra
Could you share the above message to @guillaumebernard84 ? :)

@guillaumebernard84
Copy link
Collaborator

Hi @guillaumebernard84, Thank you for your valuable contributions to the French localization so far! Please review the Policy for Localization Approvers (Pending Candidate Confirmation) #723. After review it, please leave a comment on this PR to confirm that you've read and understood the policy. :)

Hello @seokho-son , I have read and understood the policy 👍

@seokho-son
Copy link
Collaborator

Thanks!

After cncf/people#289 , I am going to merge this PR. :)

Copy link
Collaborator

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@seokho-son seokho-son merged commit 04efcaa into cncf:main Sep 12, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainers Use this label if PR requires maintainers to take action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants