-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @guillaumebernard84 as an fr approver #2370
Conversation
Signed-off-by: Stéphane Este-Gracias <[email protected]>
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is well deserved !
Hi @guillaumebernard84, |
Hi @sestegra |
Hello @seokho-son , I have read and understood the policy 👍 |
Thanks! After cncf/people#289 , I am going to merge this PR. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Describe your changes
In recognition of @guillaumebernard84's dedicated contributions to the French localization team, this PR elevates him to the role of approver.
Related issue number or link (ex:
resolves #issue-number
)N/A
Checklist before opening this PR (put
x
in the checkboxes)git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.