-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve interoperability with scipy #93
base: master
Are you sure you want to change the base?
Conversation
replaced pull_zyx calls with pull
Codecov Report
@@ Coverage Diff @@
## master #93 +/- ##
==========================================
- Coverage 91.70% 91.68% -0.02%
==========================================
Files 461 472 +11
Lines 7148 7628 +480
==========================================
+ Hits 6555 6994 +439
- Misses 593 634 +41
Continue to review full report at Codecov.
|
Put this in "Draft" state again, because I'd like to change the API as discussed in #49 (comment) |
This is for @tlambert03 @jni ;-)
I extended the API to be compatible to both worlds (clij and scipy). I added parameters such as
axes
andangle
torotate
andmatrix
toaffine_transform
. Furthermore, I added the aliaseszoom
forwarding toscale
andshift
forwarding totranslate
. Also those two have the right parameters to be compatible to scipy (to some degree). I'm considering to make them independent functions, and no aliases, that would mean doubled functionality, but it might be easier to maintain. What do you think?More sophisticated parameters such as
mode{‘reflect’, ‘constant’, ‘nearest’, ‘mirror’, ‘wrap’}, optional
in zoom andorder
inaffine_transform
are a bit above my abilities. PRs welcome ;-)Check out the notebook for details (edit: link fixed)
Teaser: