Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve interoperability with scipy #93

Draft
wants to merge 27 commits into
base: master
Choose a base branch
from

Conversation

haesleinhuepf
Copy link
Member

@haesleinhuepf haesleinhuepf commented Jan 11, 2021

This is for @tlambert03 @jni ;-)

I extended the API to be compatible to both worlds (clij and scipy). I added parameters such as axes and angle to rotate and matrix to affine_transform. Furthermore, I added the aliases zoom forwarding to scale and shift forwarding to translate. Also those two have the right parameters to be compatible to scipy (to some degree). I'm considering to make them independent functions, and no aliases, that would mean doubled functionality, but it might be easier to maintain. What do you think?

More sophisticated parameters such as mode{‘reflect’, ‘constant’, ‘nearest’, ‘mirror’, ‘wrap’}, optional in zoom and order in affine_transform are a bit above my abilities. PRs welcome ;-)

Check out the notebook for details (edit: link fixed)

Teaser:
image

@codecov-io
Copy link

codecov-io commented Jan 11, 2021

Codecov Report

Merging #93 (fbb49e8) into master (8f06000) will decrease coverage by 0.01%.
The diff coverage is 94.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
- Coverage   91.70%   91.68%   -0.02%     
==========================================
  Files         461      472      +11     
  Lines        7148     7628     +480     
==========================================
+ Hits         6555     6994     +439     
- Misses        593      634      +41     
Impacted Files Coverage Δ
...e/_tier1/_downsample_slice_by_slice_half_median.py 100.00% <ø> (ø)
...nto_prototype/_tier1/_write_values_to_positions.py 65.00% <0.00%> (ø)
...otype/_tier3/_exclude_labels_outside_size_range.py 100.00% <ø> (ø)
..._tier3/_exclude_labels_with_values_out_of_range.py 100.00% <ø> (ø)
pyclesperanto_prototype/_tier3/_histogram.py 100.00% <ø> (ø)
...speranto_prototype/_tier9/_artificial_tissue_2d.py 3.22% <0.00%> (ø)
...type/_tier9/_centroids_of_background_and_labels.py 100.00% <ø> (ø)
...esperanto_prototype/_tier9/_centroids_of_labels.py 100.00% <ø> (ø)
pyclesperanto_prototype/_tier9/_imread.py 33.33% <0.00%> (ø)
pyclesperanto_prototype/_tier9/_imshow.py 13.33% <0.00%> (ø)
... and 171 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f06000...fbb49e8. Read the comment docs.

@haesleinhuepf haesleinhuepf marked this pull request as draft January 12, 2021 15:36
@haesleinhuepf
Copy link
Member Author

Put this in "Draft" state again, because I'd like to change the API as discussed in #49 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants