Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom read zero outside image #301

Open
wants to merge 7 commits into
base: morph_snake_smoothing
Choose a base branch
from

Conversation

haesleinhuepf
Copy link
Member

@haesleinhuepf haesleinhuepf commented Apr 23, 2023

Hey @grahamross123 ,

I eventually managed to look into #296 . Big thanks for working on this!

In this PR to your branch I add a custom read-function based on the original in the preamble. It returns 0 if the coordinates are outside the image.

I'm also adding some tests demonstrating that it now works like in skimage also on image borders.

I created an issue because the read-zero-outside thingy should be supported by the preamble, but is commented out. See #302

Let me know what you think! And thanks again!

Best,
Robert

@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2023

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.02%. Comparing base (e972ab0) to head (8c00111).
Report is 5 commits behind head on morph_snake_smoothing.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                    Coverage Diff                    @@
##           morph_snake_smoothing     #301      +/-   ##
=========================================================
+ Coverage                  92.95%   93.02%   +0.07%     
=========================================================
  Files                        773      776       +3     
  Lines                      14237    14340     +103     
=========================================================
+ Hits                       13234    13340     +106     
+ Misses                      1003     1000       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants