Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve clij3 architecture #8

Open
StRigaud opened this issue Sep 29, 2024 · 5 comments
Open

improve clij3 architecture #8

StRigaud opened this issue Sep 29, 2024 · 5 comments

Comments

@StRigaud
Copy link
Member

For now all the code is in the CLIJ3.java file.

Could it be possible to split the core code and the auto-generated code into 2 files? To facilitate maintenance and development

CC @haesleinhuepf

@haesleinhuepf
Copy link
Member

I would also say, we should move the CLIJ3 class into a clij3 package. Does anything speak agains this?

@StRigaud
Copy link
Member Author

i don't know, maybe @tinevez or @carlosuc3m can give us a hint on this

@tinevez
Copy link

tinevez commented Sep 30, 2024

I would stick to the 'split the class if it is >1000 lines'.
We want to promote maintainability, so splitting core vs autogenerated makes sense as well.
Does it make sense not to?

@haesleinhuepf
Copy link
Member

Yes splitting makes sense! The auto-generated part was also in a separate file in CLIJ2.

@carlosuc3m
Copy link
Member

yess, better to split it!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants