Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kernel detect minima #151

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

CherifMZ
Copy link
Contributor

No description provided.

@StRigaud StRigaud self-requested a review March 28, 2023 12:34
@CherifMZ
Copy link
Contributor Author

CherifMZ commented Mar 30, 2023

I believe there is an error in the detect_minima kernel because it does not seem to always detect the minimum value when it is located at the bottom or on the right edge of the matrix.

edit: : I noticed the same problem for the detect_maxima kernel. I also added a test in which detecting the minimal/maximal value when it is located in the center of a 3D array does not work.

@StRigaud StRigaud added request New feature or request kernel labels Apr 11, 2023
Comment on lines 10 to 15
{
std::string cl_header = {
#include "cle_detect_minima.h"
};
this->SetSource("detect_minima", cl_header);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Library was updated, this need to be changed as followed:

  • move the include outside the function, at the top of the file
  • replace cl_header by oclKernel::detect_minima

see: absolute kernel for example

@StRigaud StRigaud removed the kernel label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
request New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants